Skip to content

feat: introduce timeout #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 6 commits into from
Jun 30, 2022
Merged

feat: introduce timeout #45

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f7fcaf
chore: handle timeouts
strophy Jun 22, 2022
99a9898
chore: set timeout to undefined if not defined
strophy Jun 23, 2022
99f2ca6
fix: no need to set undefined default for this.timeout
strophy Jun 23, 2022
72caa83
Update lib/index.js
strophy Jun 23, 2022
4e04dd0
fix: mocha timeout test doesn't time out
strophy Jun 28, 2022
c30fee3
chore: timeout after timeout elapses
strophy Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: mocha timeout test doesn't time out
  • Loading branch information
@strophy
strophy committed Jun 28, 2022
commit 4e04dd0440173939440743073d997b5dfbaf2979
46 changes: 27 additions & 19 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,24 +525,32 @@ describe('RpcClient', function() {

});

});

it('should throw error when timeout is triggered', (done) => {
var client = new RpcClient({
user: 'user',
pass: 'pass',
host: '127.0.0.1',
port: 1000,
});
it('should throw error when timeout is triggered', (done) => {
var client = new RpcClient({
user: 'user',
pass: 'pass',
host: 'localhost',
port: 8332,
});

client.httpOptions = {
timeout: 100
};
client.httpOptions = {
timeout: 100
};

var requestStub = sinon.stub(client.protocol, 'request').callsFake(function (options, callback) {
var req = new FakeRequest();
setTimeout(function () {
req.emit('timeout');
}, options.timeout + 200);
return req;
});

client.getDifficulty((error, parsedBuf) => {
should.exist(error);
should.not.exist(parsedBuf);
error.message.should.equal('Timeout Error: 100ms exceeded')
done();
})
});
client.getDifficulty((error, parsedBuf) => {
should.exist(error);
should.not.exist(parsedBuf);
error.message.should.equal(`Timeout Error: ${client.httpOptions.timeout}ms exceeded`);
requestStub.restore();
done();
})
});
})