Skip to content

Conversation

@strophy
Copy link
Contributor

@strophy strophy commented Jul 5, 2022

Smoke tests were returning errors in CI:

Error: Callback was already called.
    at /usr/src/app/node_modules/async/dist/async.js:321:36
    at newCallback (/usr/src/app/node_modules/@dashevo/dashd-rpc/lib/index.js:59:7)
    at ClientRequest.<anonymous> (/usr/src/app/node_modules/@dashevo/dashd-rpc/lib/index.js:146:7)
    ...

Use of the debugger revealed information about the request/response sent in the first callback function, and timeout messages being sent to the callback function in a second run. This PR fixes it, although I'm not entirely sure if this is how the called variable is supposed to be used.

@strophy strophy requested a review from shumkov July 5, 2022 12:45
@shumkov shumkov changed the title fix: Callback was already called fix: сallback was already called Jul 5, 2022
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants