Update clkhash for tutorials #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clkhash 0.15.0 uses only one secret to hash.
wilko77
approved these changes
Nov 18, 2019
Collaborator
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
Although not exactly in the scope of this PR, but it would be nice if you could run those old v1 schemas through the converter (clkutil convert-schema).
👍 for pinning the clkhash version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of fun: in the PR #464 some tutorials were failing. After observation, it is due to the recent release of clkhash: in v0.15.0 of clkhash, a number of apis and changes are breaking changes.
However, the container testing the tutorials was not pointing to a precise version of clkhash, but to a version greater or equal to 0.13.0.
In this PR, I upgraded the version, and did a number of changes to have the tutorials working. I have NOT updated the tutorials to use the schema v3. Should it be there here? Otherwise I can open an issue about it.