Updates production deployment documentation. #473
Conversation
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
apart from the comments. There are some tests failing...
|
|
||
| To run with minikube for local testing we have provided a ``minimal.yaml`` file that will | ||
| set very small resource limits. Install the minimal system with:: | ||
| To run with minikube for local testing we have provided a ``minimal.yaml`` configuration file that will |
There was a problem hiding this comment.
where is that minimal.yaml file? I couldn't find it in the deployment folder.
There was a problem hiding this comment.
Hmm, I would have sworn there was one. I'll remove the reference as it was so minimal it couldn't do much except deploy the service
| env: | ||
| - name: ENTITY_SERVICE_URL | ||
| value: https://beta.anonlink.data61.xyz/api/v1 | ||
| value: https://anonlink.easd.data61.xyz/api/v1 |
There was a problem hiding this comment.
why do we define the server differently to the benchmark yaml? Is there a reason for this inconsistency?
Wouldn't it be nicer if they both accepted the same name/value pair?
| containers: | ||
| - name: entitytester | ||
| image: quay.io/n1analytics/entity-app | ||
| image: data61/anonlink-app:v1.12.0 |
There was a problem hiding this comment.
wouldn't it be better to link to latest or stable or something similar. We don't want to update the deployment files with every release.
There was a problem hiding this comment.
Sure, happy to use latest. It is mostly there as an example, and pinning exact versions of what runs is considered best practice.
There was a problem hiding this comment.
I'll remove the log level setting from here too - it is just for the logging level during tests which pytest overrides anyway.
|
Thanks for the review @wilko77 - have addressed the inconsistencies in the documentation and opened an issue for the env var. |
hardbyte
force-pushed
the
fix-deploment-links
branch
from
2da4f50 to
8ac9447
Compare
This started as just updating a dead hyperlink but has ended up being misc updates to the Kubernetes deployment docs.
Closes #471