Release: app version 1.13.0-beta, frontend version 1.4.6-beta #498
Conversation
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
just a bit more polish to the changelog please.
| name: {{ .Release.Name }}-worker | ||
| minReplicas: {{ required "workers.replicaCount must be provided." .Values.workers.replicaCount }} | ||
| maxReplicas: 20 | ||
| maxReplicas: {{ required "workers.autoscaler.maxReplicas must be provided." .Values.workers.autoscaler.maxReplicas }} |
There was a problem hiding this comment.
<nitpick mode ON>
the two parameters minReplicas and maxReplicas are clearly related. Why do we set them at different levels in the Values file?
<upgrade to double nitpick mode NOW>
Why do we set the minReplicas value as replicaCount? Wouldn't that just confuse some random DevOps guy when (s)he tries to configure the autoscaler?/
<all nitpick modes OFF>
There was a problem hiding this comment.
We set them at different levels because replicaCount is always required (whether the autoscaler is enabled or not), and I just decided that if the autoscaler is enabled we would use the initial number of replicas as the minimum. I'll add another configurable: workers.autoscaler.minReplicas.
docs/changelog.rst
Outdated
| Version 1.13.0-beta | ||
| ------------------- | ||
|
|
||
| - fixed a bug where a dataprovider could upload their clks multiple time in a project using the same upload token (#463) |
There was a problem hiding this comment.
mix of singular and plural. Yes, we celebrate diversity, but that might take it just a tad too far.
docs/changelog.rst
Outdated
| - Update dependencies: | ||
| - We have enabled `dependabot <https://dependabot.com/>`_ on GitHub to keep our Python dependencies up to date. | ||
| - ``anonlinkclient`` now used for benchmarking (#490) | ||
| - Chart dependencies ``redis-ha``, ``postgres`` and ``minio`` all updated. |
There was a problem hiding this comment.
can you link to the corresponding PR, please?
docs/changelog.rst
Outdated
| - the ``similarity_score`` output type has been modified, it now returns a JSON array of JSON objects, where such an object | ||
| looks like `[[party_id_0, row_index_0], [party_id_1, row_index_1], score]`. (#464) | ||
| - Integration test configuration is now consistent with benchmark config. Instead of setting ``ENTITY_SERVICE_URL`` including | ||
| ``/api/v1`` now just set the host address in ``SERVER``. |
docs/changelog.rst
Outdated
| Version 1.13.0-beta | ||
| ------------------- | ||
|
|
||
| - fixed a bug where a dataprovider could upload their clks multiple time in a project using the same upload token (#463) |
Changes since 1.12.0:
Version 1.13.0-beta
similarity_scoreoutput to follow the group format, which will simplify extending this output type to more parties (Feature similarity groups #464)dependabot <https://dependabot.com/>_ on GitHub to keep our Python dependencies up to date.anonlinkclientnow used for benchmarking (Fix dependencies and migrate benchmark auth #490)redis-ha,postgresandminioall updated.Breaking Changes
dataproviderstableuploadedfield has been modified from a BOOL to an ENUM type (Fix 462 #463)similarity_scoreoutput type has been modified, it now returns a JSON array of JSON objects, where such an objectlooks like
[[party_id_0, row_index_0], [party_id_1, row_index_1], score]. (Feature similarity groups #464)ENTITY_SERVICE_URLincluding/api/v1now just set the host address inSERVER.Version 1.13.0-alpha
fixed bug where invalid state changes could occur when starting a run (Fix starting runs #459)
matchingoutput type has been removed as redundant with thegroupsoutput with 2 parties. (Feature delete mapping #458)Update dependencies:
Breaking Change
matchingoutput type is not available anymore. (Feature delete mapping #458)