Feature separate base image #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
force-pushed
the
feature-separate-base-image
branch
from
9b668c6 to
47ce340
Compare
Collaborator
Author
|
(Rebased) |
hardbyte
force-pushed
the
feature-separate-base-image
branch
from
c0c5ff0 to
00f9ca5
Compare
wilko77
approved these changes
Feb 19, 2020
Collaborator
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
the only question left is how are we going to monitor the availability of newer versions of all the pinned dependencies?
Use requirements hash as version of base image By default don't wait for base image build. Skip build base image if it exists with correct hash on dockerhub.
hardbyte
force-pushed
the
feature-separate-base-image
branch
from
5615773 to
0100017
Compare
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #437 by introducing a new layer of docker image for our "base" dependencies.
I'll clean up the commit history and remove the commented out azure debugging code but it would be good to get feedback.
After changing a dependency the building of the base image blocks the building off the app:
When the dependencies don't change the app builds nice and fast: