Detect invalid encoding size earlier #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceyuu
approved these changes
Feb 20, 2020
Contributor
joyceyuu
left a comment
joyceyuu
left a comment
There was a problem hiding this comment.
Look good to me. You might need to update branch before merging it
| k=min(chunk_dp1_size, chunk_dp2_size)) | ||
| except NotImplementedError as e: | ||
| log.warning("Encodings couldn't be compared using anonlink.") | ||
| return |
Contributor
There was a problem hiding this comment.
return nothing? Is this equivalent to return None?
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured I'd pay back some technical debt before embarking on my next feature.
Closes #442