Skip build in bash if azure isn't playing along #511
Conversation
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
I'd prefer if we change the skip to a Boolean. Then, the condition would become not(${{ parameters.skip }}) and the default default: false. No need for the extra bash script checking stuff.
| imageName: data61/anonlink-app | ||
| # this part is still todo automated | ||
| dockerBuildArgs: "--build-arg VERSION=02a973ce02c96d24376c5770c0426ccb0958a0d59136a4f2fc11c8666c43062a" | ||
| dockerBuildArgs: "--build-arg VERSION=ed0be6ee130ec505b2a65af26ba570e1033ffb7e0cc6b27b6a8520df94f65d20" |
There was a problem hiding this comment.
this is really annoying. When we change the base image requirements, although a new version gets build, it will not be tested. We already had a non-functioning base image. We really need to find a way to test the new base images straight away.
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
ok, that was a bit of a premature recommendation, as I can't make that work within our context.
I guess we just merge this in for now until someone with magic Azure-pipeline-superpowers comes along and guides us out of this misery...
|
Agree it could be nicer if Azure was a bit easier to use. Have added the need to automate using and testing the latest base image to the backlog. |
|
Oh that is annoying, I set the merge target as |
The condition in azure didn't seem to take effect so we now check whether to skip the expensive image building in bash. I've tried various combinations of using strings and booleans in the main azure script and docker build template and cannot make Azure Pipelines do what I expect.
I updated the base digest too