Split e2e tests out #528
Merged
Split e2e tests out #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceyuu
approved these changes
Mar 13, 2020
Contributor
joyceyuu
left a comment
joyceyuu
left a comment
There was a problem hiding this comment.
Nice! I should learn this test separation for anonlink-client as well
| containers: | ||
| - name: entitytester | ||
| image: $IMAGE_NAME_WITH_TAG | ||
| image: $TEST_E2E_IMAGE_NAME_WITH_TAG |
Contributor
There was a problem hiding this comment.
What does E2E stand for? end to end? from which end to which end?
Collaborator
Author
There was a problem hiding this comment.
Yup end to end, here it means tests that only use the public REST api. We could expand further, or add another level to test the integration between client apps and the server.
| # itertools.product(PROJECT_RESULT_TYPES_2P, [1, 3, 4, 5]), | ||
| # [(t, 1) for t in PROJECT_RESULT_TYPES_NP])) | ||
| # def invalid_result_type_number_parties(request): | ||
| # yield request.param |
Contributor
There was a problem hiding this comment.
Is this an accident? whole file is commented out?
Collaborator
Author
There was a problem hiding this comment.
Thanks, the contents has moved into the e2e test folder - I'll delete this commented out stuff.
hardbyte
force-pushed
the
create-comparisons-to-use-blocking
branch
2 times, most recently
from
5c8b6a2 to
5467362
Compare
hardbyte
changed the base branch from
create-comparisons-to-use-blocking
to
develop
hardbyte
force-pushed
the
split-e2e-tests-out
branch
from
a2b5d41 to
a48cf3d
Compare
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the e2e tests and the unit tests.
Adds a new docker container
anonlink-test.