Skip to content

Release v1.13.0 beta.2 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardbyte merged 4 commits into from
Apr 30, 2020
Merged

Release v1.13.0 beta.2 #553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e7f82c
Update benchmark version
hardbyte Apr 30, 2020
32a94c1
Add changelog for v1.13.0-beta2
hardbyte Apr 30, 2020
aba4ba1
Remove deprecated debug flag from k8s config
hardbyte Apr 30, 2020
d68f8ef
Increase chance of a flaky test passing
hardbyte Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecated debug flag from k8s config
  • Loading branch information
@hardbyte
hardbyte committed Apr 30, 2020
commit aba4ba1a54b55450cbffe1c5bb7c9cc3201953d9
2 changes: 0 additions & 2 deletions deployment/entity-service/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ metadata:
labels:
{{- include "es.release_labels" . | indent 4 }}
data:
DEBUG: {{ required "workers.debug is required." .Values.workers.debug | quote }}
Copy link
Collaborator

@wilko77 wilko77 Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was that for? Why don't we need it anymore?

Copy link
Collaborator Author

@hardbyte hardbyte Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug flag was removed ages ago from the python code and settings. Has just taken a while to remove all traces - now we configure logging in a different config map.


CONNEXION_STRICT_VALIDATION: "true"
CONNEXION_RESPONSE_VALIDATION: "true"

Expand Down
2 changes: 0 additions & 2 deletions deployment/entity-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,6 @@ workers:
## Worker configuration
## These settings populate the deployment's configmap.

debug: false

## Desired task size in "number of comparisons"
## Note there is some overhead creating a task and a single dedicated cpu core can do between 50M and 100M
## comparisons per second, so much lower that 100M isn't generally worth splitting across celery workers.
Expand Down