Skip to content

Comments

fix mongo, mysql mode; show pip install info; etc#94

Merged
dataabc merged 3 commits intodataabc:multi-filefrom
songzy12:master
Nov 17, 2019
Merged

fix mongo, mysql mode; show pip install info; etc#94
dataabc merged 3 commits intodataabc:multi-filefrom
songzy12:master

Conversation

@songzy12
Copy link
Collaborator

  1. 修正了 mongo 和 mysql mode 上存在的问题:将 "user_id" 调整成了 "id"
  2. merge 了 master 上 mongo exception 的提示信息,并且在 mysql 上添加了类似的提示信息。
  3. 参考 master 上对 csv 写时的操作,当前应该支持 python2 了。

上面这些我自己大体测了一遍,虽然有可能会测得不准 2333

dataabc and others added 2 commits November 16, 2019 22:31
若使用者配置程序为将结果写入MongoDB数据库,且MongoDB或pymongo没有安装/启动,则给出相应提示
@songzy12 songzy12 force-pushed the master branch 3 times, most recently from 46a8de3 to 0627bc3 Compare November 17, 2019 13:19
1. fix mongo
2. fix mysql
3. support python2
@dataabc dataabc merged commit c3fef3a into dataabc:multi-file Nov 17, 2019
@dataabc
Copy link
Owner

dataabc commented Nov 17, 2019

感谢贡献代码。

本来我准备回复上一条PR,这时候发现代码已经修改好并推送过来了,神速,效率非常高。然后我又测试了几遍,没有问题。本来打算看到代码就立即测试和回复的,因为有些事情耽误了,现在才弄完。由衷佩服:

  • 效率非常高 X 233
  • 代码非常清晰 X 233
  • 格式非常优雅 X 233

虽然已经说过很多遍了,还要再说亿遍:

  • 非常感谢贡献代码 X 233

棒棒哒

@songzy12
Copy link
Collaborator Author

哈哈没问题太好啦。

作者也棒棒哒。😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants