Skip to content

fix: patched-base encoding producing empty patch list #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenyXu merged 4 commits into from
Dec 19, 2025
Merged

fix: patched-base encoding producing empty patch list #74

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06159e6
added simple test for patched base encoding based on ORC v2 spec
Dec 11, 2025
3974efa
fixed computation of max value bit width in patched base encoding
Dec 11, 2025
7e8642d
added test to check that patched base encoding is not used if bit wid…
Dec 11, 2025
0096a12
fix formatting
Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed computation of max value bit width in patched base encoding
  • Loading branch information
Baptiste Mehat committed Dec 11, 2025
commit 3974efa99307b8a608abbbc79f3d0a8fdece8840
2 changes: 1 addition & 1 deletion src/encoding/integer/rle_v2/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ fn determine_variable_run_encoding<N: NInt, S: EncodingSign>(
}

// Aka 100th percentile
let base_reduced_literals_max_bit_width = max_data_value.closest_aligned_bit_width();
let base_reduced_literals_max_bit_width = max_data_value.bits_used();
// 95th percentile width is used to find the 5% of values to encode with patches
let base_reduced_literals_95th_percentile_bit_width =
calculate_percentile_bits(&base_reduced_literals, 0.95);
Expand Down