Skip to content

refactor(frontend): fails loudly to help debug gms issue #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mars-lan merged 1 commit into from
Apr 3, 2020
Merged

refactor(frontend): fails loudly to help debug gms issue #1626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(frontend): fails loudly to help debug gms issue 
This will print the full stacktrace in log to help identify various gms issues
  • Loading branch information
Mars Lan committed Apr 3, 2020
commit 16e62c45f35e3faf1b101c0bc4c5344440999afc
3 changes: 1 addition & 2 deletions datahub-frontend/app/controllers/api/v1/User.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import utils.ControllerUtil;

import javax.annotation.Nonnull;
import java.security.InvalidParameterException;
import java.util.Collections;
import java.util.List;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -49,7 +48,7 @@ public Result getLoggedInUser() {
try {
corpUser = _corpUserViewDao.getByUserName(username);
} catch (Exception e) {
throw new InvalidParameterException("Invalid username: " + username);
throw new RuntimeException(e);
}

if (corpUser == null || !corpUser.getUsername().equals(username)
Expand Down