Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
e915ee0
Add feast testing setup
kevinhu May 18, 2021
c193107
Init Feast test script
kevinhu May 18, 2021
8ad6c30
Add feast to dependencies
kevinhu May 18, 2021
0f6a674
Update feast descriptors
kevinhu May 18, 2021
a94ccef
Sort integrations
kevinhu May 18, 2021
471fe1b
Working feast pytest
kevinhu May 18, 2021
afd2aa1
Clean up feast docker-compose file
kevinhu May 18, 2021
65d3d52
Expand Feast tests
kevinhu May 18, 2021
4212acb
Setup feast classes
kevinhu May 19, 2021
f4f431f
Add continuous and bytes data to feature types
kevinhu May 19, 2021
4790882
Update field type mapping
kevinhu May 19, 2021
afe1fe1
Add PDLs
kevinhu May 19, 2021
60f8b99
Add MLFeatureSetUrn.java
kevinhu May 19, 2021
65744b7
Comment out feast setup
kevinhu May 19, 2021
4293385
Add snapshot file and update inits
kevinhu May 19, 2021
140c026
Merge
kevinhu May 20, 2021
9217feb
Init Feast golden files generation
kevinhu May 21, 2021
e56a3c3
Clean up Feast ingest
kevinhu May 21, 2021
7e8c57c
Feast testing comments
kevinhu May 21, 2021
0bc5531
Merge branch 'master' of github.com:kevinhu/datahub into feast-integr…
kevinhu May 21, 2021
98f3e6d
Yield Feature snapshots
kevinhu May 21, 2021
97847e5
Fix Feature URN naming
kevinhu May 21, 2021
d3f2698
Update feast MCE
kevinhu May 21, 2021
e852809
Update Feature URN prefix
kevinhu May 21, 2021
239b6fa
Merge branch 'master' of github.com:kevinhu/datahub into feast-integr…
kevinhu May 24, 2021
b35feac
Add MLEntity
kevinhu May 24, 2021
86c9e7a
Update golden files with entities
kevinhu May 24, 2021
73139ec
Specify feast sources
kevinhu May 24, 2021
8db06b4
Add feast source configs
kevinhu May 24, 2021
7a52f4a
Working feast docker ingestion
kevinhu May 25, 2021
d49cf03
Merge branch 'linkedin:master' into feast-integration
kevinhu May 25, 2021
4192fde
Merge branch 'master' of github.com:kevinhu/datahub into feast-integr…
kevinhu May 25, 2021
4c5da86
List entities and features before adding tables
kevinhu May 25, 2021
adc3186
Add featureset names
kevinhu May 25, 2021
62f0bc2
Remove unused
kevinhu May 25, 2021
dd35065
Rename feast image
kevinhu May 25, 2021
95b944d
Update README
kevinhu May 25, 2021
9138d33
Merge branch 'master' of https://github.com/linkedin/datahub into fea…
kevinhu May 25, 2021
1c64525
Add env to feast URNs
kevinhu May 25, 2021
857b620
Fix URN naming
kevinhu May 25, 2021
c317dd2
Remove redundant URN names
kevinhu May 25, 2021
d664006
Fix enum backcompatibility
kevinhu May 25, 2021
908ba6a
Move feast testing to docker
kevinhu May 25, 2021
ca9fe80
Move URN generators to mce_builder
kevinhu May 26, 2021
8d2270a
Add source for features
kevinhu May 26, 2021
3205d36
Switch TypeClass -> enum_type
kevinhu May 26, 2021
903eb59
Rename source -> sourceDataset
kevinhu May 26, 2021
1a68b53
Add local Feast ingest image builds
kevinhu May 26, 2021
80b147a
Rename Entity -> MLPrimaryKey
kevinhu May 27, 2021
1716cec
Restore features and keys for each featureset
kevinhu May 27, 2021
b57a5f5
Do not json encode source configs
kevinhu May 27, 2021
6b1ceb2
Remove old source properties from feature sets
kevinhu May 27, 2021
b210599
Regenerate golden file
kevinhu May 27, 2021
d0372d9
Fix race condition with Feast tests
kevinhu May 27, 2021
4c99f83
Exclude unknown source
kevinhu May 27, 2021
39733d9
Merge branch 'master' of https://github.com/linkedin/datahub into fea…
kevinhu May 27, 2021
4fac64b
Update feature datatype enum
kevinhu May 27, 2021
13d1aa9
Update README and fix typos
kevinhu May 27, 2021
b8e57c9
Fix Entity typo
kevinhu May 27, 2021
7bcb799
Fix path to local docker image
kevinhu May 27, 2021
1d0d7a7
Specify feast config and version
kevinhu May 27, 2021
b0e056f
Fix feast env variables
kevinhu May 27, 2021
e51f9a4
PR fixes
kevinhu May 27, 2021
716a8e6
Refactor feast ingest constants
kevinhu May 27, 2021
ed76075
Make feature sources optional for back-compatibility
kevinhu May 27, 2021
0e78ed9
Remove unused GCP files
kevinhu May 27, 2021
f3a4bdb
Merge branch 'master' of https://github.com/linkedin/datahub into fea…
kevinhu May 27, 2021
47fced1
adding docker publish workflow
shirshanka May 27, 2021
6559e5e
Simplify name+namespace in PrimaryKeys
kevinhu May 27, 2021
5efc917
Merge branch 'feast-integration' of github.com:acryldata/datahub-fork…
kevinhu May 27, 2021
9c8f45b
adding docker publish workflow
shirshanka May 27, 2021
6ac9718
debug
shirshanka May 27, 2021
a51b467
final attempt
shirshanka May 27, 2021
e310f19
final final attempt
shirshanka May 27, 2021
7aefc3f
final final final commit
shirshanka May 27, 2021
7de3330
Switch to published ingestion image
kevinhu May 28, 2021
fbc8648
Update name and namespace in java files
kevinhu May 28, 2021
d5f56fb
Rename FeatureSet -> FeatureTable
kevinhu May 28, 2021
27f1702
Merge branch 'master' of https://github.com/linkedin/datahub into fea…
kevinhu May 28, 2021
fb0247a
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 2, 2021
e263085
Merge
kevinhu Jun 3, 2021
b42083b
Regenerate codegen
kevinhu Jun 3, 2021
e36a1d5
Fix initial generation errors
kevinhu Jun 3, 2021
0a021e7
Update snapshot jsons
kevinhu Jun 3, 2021
6d9e7d6
Regenerated schemas
kevinhu Jun 4, 2021
d8e69f4
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 4, 2021
c971322
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 4, 2021
54e49bc
Fix URN formats
kevinhu Jun 5, 2021
fefb7db
Merge branch 'feast-integration' of github.com:kevinhu/datahub into f…
kevinhu Jun 5, 2021
360edda
Revise builds
kevinhu Jun 5, 2021
3f11e45
Clean up feast URN builders
kevinhu Jun 5, 2021
597863d
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 7, 2021
609054d
Fix naming typos
kevinhu Jun 7, 2021
810a640
Merge branch 'feast-integration' of github.com:kevinhu/datahub into f…
kevinhu Jun 7, 2021
b629aad
Fix Feature Set -> Feature Table
kevinhu Jun 7, 2021
3f5e083
Fix comments
kevinhu Jun 7, 2021
3f19c47
PR fixes
kevinhu Jun 7, 2021
e314de3
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 7, 2021
ca85381
All you need is Urn
kevinhu Jun 7, 2021
4e8cb2e
Regenerate snapshots and update validation
kevinhu Jun 7, 2021
1494205
Add UNKNOWN data type
kevinhu Jun 7, 2021
bd64aac
URNs for source types
kevinhu Jun 7, 2021
4ae725b
Add note on docker requirement
kevinhu Jun 8, 2021
a646766
Fix typo
kevinhu Jun 8, 2021
249a69d
Reorder aspect unions
kevinhu Jun 8, 2021
7d4ed43
Refactor feast ingest functions
kevinhu Jun 8, 2021
fb3c726
Update snapshot jsons
kevinhu Jun 8, 2021
f155294
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 8, 2021
5e4d778
Merge branch 'linkedin:master' into feast-integration
kevinhu Jun 9, 2021
4726ac1
Rebuild
kevinhu Jun 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add local Feast ingest image builds
  • Loading branch information
kevinhu committed May 26, 2021
commit 1a68b5332e0f9d05bf341fba4355ad8412785cce
17 changes: 16 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/feast.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class FeastConfig(ConfigModel):
# https://pymongo.readthedocs.io/en/stable/examples/authentication.html
core_url: str = "localhost:6565"
env: str = DEFAULT_ENV
use_local_build: bool = False


@dataclass
Expand Down Expand Up @@ -101,8 +102,18 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]:
with tempfile.NamedTemporaryFile(suffix=".json") as tf:

docker_client = docker.from_env()

# image to use for initial feast extraction
feast_image = "feast-ingest"

# build the image locally if specified
if self.config.use_local_build:
image, _ = docker_client.images.build(path="../feast_image/")

feast_image = image.id

docker_client.containers.run(
"feast-ingest",
feast_image,
f'python3 ingest.py --core_url="{self.config.core_url}" --output_path=/out.json',
# allow the image to access the core URL if on host
network_mode="host",
Expand Down Expand Up @@ -132,6 +143,10 @@ def get_workunits(self) -> Iterable[MetadataWorkUnit]:
MLFeaturePropertiesClass(
name=feature["name"],
dataType=self.get_field_type(feature["type"], feature["name"]),
# TODO: update this
sourceDataset=builder.make_dataset_urn(
"test", "test", self.config.env
),
)
)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# ignore Feast image outputs
mlruns
8 changes: 4 additions & 4 deletions metadata-ingestion/tests/integration/feast/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ services:
- --spring.config.location=classpath:/application.yml,file:/etc/feast/application.yml

setup:
image: feast-ingest
# build from the same Feast image used for ingestion
build: ../../../src/datahub/ingestion/source/feast_image/
volumes:
- ./make_tests.py:/app/make_tests.py
- ./wait-for-it.sh:/app/wait-for-it.sh
depends_on:
- core
command:
./wait-for-it.sh testfeast:6565 -- python3 make_tests.py
# - ls
# wait for Feast to start, then insert test data
command: ./wait-for-it.sh testfeast:6565 -- python3 make_tests.py

db:
image: postgres:12-alpine
Expand Down