Skip to content

fix(react): url encoding urns and tag profile fix #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 5 commits into from
Jun 3, 2021
Merged

fix(react): url encoding urns and tag profile fix #2623

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69e792e
fixing url encoding of urns and tag profile module
gabe-lyons May 28, 2021
353b1da
reverting console log
gabe-lyons May 28, 2021
96f7009
handling null urns
gabe-lyons Jun 2, 2021
4162b03
fixing replace logic
gabe-lyons Jun 2, 2021
b296634
adjusting rewrite logic
gabe-lyons Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handling null urns
  • Loading branch information
@gabe-lyons
gabe-lyons committed Jun 2, 2021
commit 96f7009e78d37b5ed82f85099e02039f8c002fba
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/entity/shared/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export function urlEncodeUrn(urn: string) {
return urn.replaceAll('/', '%2F').replaceAll('?', '%3F').replaceAll('%', '%25').replaceAll('#', '%23');
return urn?.replaceAll('/', '%2F').replaceAll('?', '%3F').replaceAll('%', '%25').replaceAll('#', '%23');
}