Skip to content

fix(NoCode): Fix docker image tag for run_upgrade script #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Jun 4, 2021
Merged

fix(NoCode): Fix docker image tag for run_upgrade script #2648

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa9330
Fix upgrade script
Jun 4, 2021
0bdadf4
Fix
Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/datahub-upgrade/datahub-upgrade.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd $DIR && docker pull acryldata/datahub-upgrade:head && docker run --env-file ./env/docker.env --network="datahub_network" acryldata/datahub-upgrade:latest "$@"
cd $DIR && docker pull acryldata/datahub-upgrade:head && docker run --env-file ./env/docker.env --network="datahub_network" acryldata/datahub-upgrade:head "$@"
Copy link
Contributor

@shirshanka shirshanka Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use a common variable e.g.
DOCKER_IMAGE=acryldata/datahub-upgrade:head
followed by
cd $DIR && docker pull ${DOCKER_IMAGE} && docker run --env-file ./env/docker.env --network="datahub_network" ${DOCKER_IMAGE} "$@"

Copy link
Contributor Author

@dexter-mh-lee dexter-mh-lee Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!