Skip to content

fix(ingest): support mssql encryption via ODBC #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Jun 5, 2021
Merged

fix(ingest): support mssql encryption via ODBC #2657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40392dd
fix(ingest): support mssql encryption
hsheth2 Jun 4, 2021
fb0ce85
update tests
hsheth2 Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update tests
  • Loading branch information
@hsheth2
hsheth2 committed Jun 5, 2021
commit fb0ce85dbf5b5b55bb24db8878b4da75c3e2bfc1
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class SQLServerConfig(BasicSQLAlchemyConfig):
scheme = "mssql+pytds"

use_odbc: bool = False
uri_args: Dict[str, str]
uri_args: Dict[str, str] = {}

@pydantic.validator("uri_args")
def passwords_match(cls, v, values, **kwargs):
Expand Down
5 changes: 3 additions & 2 deletions metadata-ingestion/tests/integration/sql_server/mssql_to_file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ source:
password: test!Password
database: DemoData
host_port: localhost:51433
use_odbc: False
uri_args: {}
# use_odbc: True
# uri_args:
# driver: "ODBC Driver 17 for SQL Server"

sink:
type: file
Expand Down