Fix lint errors

metadata-ingestion/src/datahub/ingestion/source/glue.py

@@ -80,7 +80,7 @@ class GlueSourceConfig(ConfigModel):
     aws_role: Optional[Union[str, List[str]]] = None
     aws_region: str
 
-    def get_client(self, service: str):
+    def get_client(self, service: str) -> boto3.client:
         if (
             self.aws_access_key_id
             and self.aws_secret_access_key

metadata-ingestion/tests/unit/test_glue_source.py

@@ -1,4 +1,3 @@
-import json
 import unittest
 from datetime import datetime
 
@@ -32,11 +31,11 @@
     get_databases_response,
     get_dataflow_graph_response_1,
     get_dataflow_graph_response_2,
+    get_jobs_response,
     get_object_body_1,
     get_object_body_2,
     get_object_response_1,
     get_object_response_2,
-    get_jobs_response,
     get_tables_response_1,
     get_tables_response_2,
 )
@@ -97,7 +96,7 @@ def test_get_column_type_not_contained(self):
             ],
         )
 
-    # @freeze_time(FROZEN_TIME)
+    @freeze_time(FROZEN_TIME)
     def test_turn_boto_glue_data_to_metadata_event(self):
         stringy_timestamp = datetime.strptime(FROZEN_TIME, "%Y-%m-%d %H:%M:%S")
         timestamp = int(datetime.timestamp(stringy_timestamp) * 1000)
@@ -149,7 +148,8 @@ def test_turn_boto_glue_data_to_metadata_event(self):
                 for wu in self.glue_source.get_workunits():
                     print(wu.mce.to_obj)
 
-        expected_metadata_work_unit = create_metadata_work_unit(timestamp)
+        create_metadata_work_unit(timestamp)
+        # expected_metadata_work_unit = create_metadata_work_unit(timestamp)
 
         # self.assertEqual(expected_metadata_work_unit, actual_work_unit)
 

metadata-ingestion/tests/unit/test_glue_source_stubs.py

@@ -1,7 +1,7 @@
-import io
 import datetime
-import botocore.session
-from botocore.stub import Stubber
+import io
+from typing import Any, Dict
+
 from botocore.response import StreamingBody
 
 get_databases_response = {
@@ -875,7 +875,7 @@
 """
 
 
-def mock_get_object_response(raw_body: str):
+def mock_get_object_response(raw_body: str) -> Dict[str, Any]:
     """
     Mock s3 client get_object() response object.
 
@@ -895,6 +895,3 @@ def mock_get_object_response(raw_body: str):
 
 get_object_response_1 = mock_get_object_response(get_object_body_1)
 get_object_response_2 = mock_get_object_response(get_object_body_2)
-
-s3 = botocore.session.get_session().create_client("s3")
-s3_stubber = Stubber(s3)