Skip to content

fix(noCode): Improving efficiency of EntityService "listLatestAspects" API #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 13 commits into from
Jun 18, 2021
Merged

fix(noCode): Improving efficiency of EntityService "listLatestAspects" API #2711

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9c527ad
Adding aspect index creation to init.sql & upgrades
jjoyce0510 Jun 16, 2021
5838384
Adding missing semicolon
jjoyce0510 Jun 17, 2021
54dabdc
Add if not exists
jjoyce0510 Jun 17, 2021
eb52a28
Use Alter table to create index on mysql
jjoyce0510 Jun 17, 2021
109eaa8
Remove if not exists
jjoyce0510 Jun 17, 2021
28534af
Altar table
jjoyce0510 Jun 17, 2021
508f9f2
Add if then to index creation
jjoyce0510 Jun 17, 2021
d6b03a1
Remove conditional index creation
jjoyce0510 Jun 17, 2021
8c4782f
only add index on table create
jjoyce0510 Jun 17, 2021
f56b08b
Add missing comma
jjoyce0510 Jun 17, 2021
85a8c46
Improving the list query
jjoyce0510 Jun 18, 2021
f66d750
removing unused datahub upgrade steps
jjoyce0510 Jun 18, 2021
6af9b7b
Removing unused config
jjoyce0510 Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add if not exists
  • Loading branch information
@jjoyce0510
jjoyce0510 committed Jun 17, 2021
commit 54dabdc5962215fef4d5774926b4b22dfe49024a
2 changes: 1 addition & 1 deletion datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/nocode/CreateAspectIndexStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public Function<UpgradeContext, UpgradeStepResult> executable() {
return (context) -> {
try {
_server.execute(_server.createSqlUpdate(
"CREATE INDEX aspectName ON metadata_aspect_v2 (aspect)"));
"CREATE INDEX IF NOT EXISTS aspectName ON metadata_aspect_v2 (aspect)"));
} catch (Exception e) {
context.report().addLine(String.format("Failed to create aspect index for metadata_aspect_v2: %s", e.toString()));
return new DefaultUpgradeStepResult(
Expand Down
2 changes: 1 addition & 1 deletion docker/mariadb/init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ create table metadata_aspect_v2 (
);

-- create index on the "aspect" column to support aspect-oriented queries.
CREATE INDEX aspectName ON metadata_aspect_v2 (aspect);
create INDEX if not exists aspectName on metadata_aspect_v2 (aspect);

insert into metadata_aspect_v2 (urn, aspect, version, metadata, createdon, createdby) values(
'urn:li:corpuser:datahub',
Expand Down
2 changes: 1 addition & 1 deletion docker/mysql-setup/init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ WHERE NOT EXISTS (SELECT * from metadata_aspect_v2);
DROP TABLE temp_metadata_aspect_v2;

-- create index on the "aspect" column to support aspect-oriented queries.
CREATE INDEX aspectName ON metadata_aspect_v2 (aspect);
CREATE INDEX IF NOT EXISTS aspectName ON metadata_aspect_v2 (aspect);

-- create metadata index table
CREATE TABLE IF NOT EXISTS metadata_index (
Expand Down
2 changes: 1 addition & 1 deletion docker/mysql/init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ CREATE TABLE metadata_aspect_v2 (
);

-- create index on the "aspect" column to support aspect-oriented queries.
CREATE INDEX aspectName ON metadata_aspect_v2 (aspect);
CREATE INDEX IF NOT EXISTS aspectName ON metadata_aspect_v2 (aspect);

INSERT INTO metadata_aspect_v2 (urn, aspect, version, metadata, createdon, createdby) VALUES(
'urn:li:corpuser:datahub',
Expand Down
2 changes: 1 addition & 1 deletion docker/postgres/init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ create table metadata_aspect_v2 (
);

-- create index on the "aspect" column to support aspect-oriented queries.
CREATE INDEX aspectName ON metadata_aspect_v2 (aspect);
CREATE INDEX IF NOT EXISTS aspectName ON metadata_aspect_v2 (aspect);

insert into metadata_aspect_v2 (urn, aspect, version, metadata, createdon, createdby) values(
'urn:li:corpuser:datahub',
Expand Down