Skip to content

fix(react): update schema description edit behavior #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 4 commits into from
Jun 18, 2021
Merged

fix(react): update schema description edit behavior #2718

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80ba546
fix(react): update schema description edit behavior
topwebtek7 Jun 18, 2021
e477e6c
fix(react): update showing add-description button on hover descriptio…
topwebtek7 Jun 18, 2021
a724060
fix(react): update descriptionmodal to dont save empty string
topwebtek7 Jun 18, 2021
6bb654b
fix(react): fix minor update in schema description
topwebtek7 Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(react): fix minor update in schema description
  • Loading branch information
@topwebtek7
topwebtek7 committed Jun 18, 2021
commit 6bb654b3aadb29a840713f7a4871e3e8b4a30d65
2 changes: 1 addition & 1 deletion datahub-web-react/src/app/entity/dataset/profile/schema/SchemaDescriptionField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function DescriptionField({ description, updatedDescription, onUp
const [showAddModal, setShowAddModal] = useState(false);

const onCloseModal = () => setShowAddModal(false);
const currentDesc: string = !!updatedDescription || updatedDescription === '' ? updatedDescription : description;
const currentDesc: string = updatedDescription || description;

const onUpdateModal = async (desc: string | null) => {
message.loading({ content: 'Updating...' });
Expand Down