Skip to content

fix(version aspects): fixes for version aspect fetching #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 3 commits into from
Jun 22, 2021
Merged

fix(version aspects): fixes for version aspect fetching #2723

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c5ab2
minor fixes for version aspect fetching
gabe-lyons Jun 20, 2021
43477ee
adding comments + refactor
gabe-lyons Jun 22, 2021
4cf4452
adding extra check to calculateVersionNumber
gabe-lyons Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/ResolverUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public static VersionedAspect getAspectFromLocalContext(DataFetchingEnvironment
Object localContext = environment.getLocalContext();
// if we have context & the version is 0, we should try to retrieve it from the fetched entity
// otherwise, we should just fetch the entity from the aspect resource
if (localContext == null && version == 0 || version == null) {
if (localContext != null && version == 0 || version == null) {
if (localContext instanceof Map) {
// de-register the prefetched aspect from local context. Since aspects will only
// ever be first-class properties of an entity type, local context will always
Expand Down
13 changes: 11 additions & 2 deletions metadata-io/src/main/java/com/linkedin/metadata/entity/ebean/EbeanEntityService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,20 @@ public Map<Urn, List<RecordTemplate>> getLatestAspects(@Nonnull final Set<Urn> u
return urnToAspects;
}

/*
* When a user tries to fetch a negative version, we want to index most recent to least recent snapshots.
* To do this, we want to fetch the maximum version and subtract the negative version from that. Since -1 represents
* the maximum version, we need to add 1 to the final result.
*/
private long calculateVersionNumber(@Nonnull final Urn urn, @Nonnull final String aspectName, @Nonnull long version) {
Copy link
Contributor

@shirshanka shirshanka Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a preconditions.assert that version is indeed negative when passed into this method?

return _entityDao.getMaxVersion(urn.toString(), aspectName) + version + 1;
}

@Override
@Nullable
public RecordTemplate getAspect(@Nonnull final Urn urn, @Nonnull final String aspectName, @Nonnull long version) {
if (version < 0) {
version = _entityDao.getMaxVersion(urn.toString(), aspectName) - version + 1;
version = calculateVersionNumber(urn, aspectName, version);
}
final EbeanAspectV2.PrimaryKey primaryKey = new EbeanAspectV2.PrimaryKey(urn.toString(), aspectName, version);
final Optional<EbeanAspectV2> maybeAspect = Optional.ofNullable(_entityDao.getAspect(primaryKey));
Expand All @@ -109,7 +118,7 @@ public VersionedAspect getVersionedAspect(@Nonnull Urn urn, @Nonnull String aspe
VersionedAspect result = new VersionedAspect();

if (version < 0) {
Copy link
Contributor

@shirshanka shirshanka Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we move this check inside the method? so callers don't have to check if version is positive or negative?

version = _entityDao.getMaxVersion(urn.toString(), aspectName) + version + 1;
version = calculateVersionNumber(urn, aspectName, version);
}

final EbeanAspectV2.PrimaryKey primaryKey = new EbeanAspectV2.PrimaryKey(urn.toString(), aspectName, version);
Expand Down