Skip to content

feat(elastic-as-graph): defaulting to elastic in quickstart #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 8 commits into from
Jun 24, 2021
Merged

feat(elastic-as-graph): defaulting to elastic in quickstart #2753

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c4bc2bb
defaulting to elastic in quickstart
gabe-lyons Jun 23, 2021
9f8110c
adding elastic option to quickstart
gabe-lyons Jun 24, 2021
5bc0a41
updating instructions
gabe-lyons Jun 24, 2021
1cd359c
improving logging
gabe-lyons Jun 24, 2021
a8410c6
removing unneeded line
gabe-lyons Jun 24, 2021
f5ba852
lint issues
gabe-lyons Jun 24, 2021
c2cd984
updating docs
gabe-lyons Jun 24, 2021
79a99ef
updating helm instructions
gabe-lyons Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improving logging
  • Loading branch information
@gabe-lyons
gabe-lyons committed Jun 24, 2021
commit 1cd359cabc1b831498a9412fe14466e51f631578
11 changes: 6 additions & 5 deletions metadata-ingestion/src/datahub/cli/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,14 @@ def check_neo4j_volume_exists():
return

if len(client.volumes.list(filters={"name": "datahub_neo4jdata"})) > 0:
click.echo("Datahub Neo4j volume found, starting with neo4j as graph service."
"If you want to run using elastic, run `datahub docker nuke` and re-ingest your data.")
click.echo("Datahub Neo4j volume found, starting with neo4j as graph service.\n"
"If you want to run using elastic, run `datahub docker nuke` and re-ingest your data.\n")
return True

click.echo("No Datahub Neo4j volume found, starting with elasticsearch as graph service."
"To use neo4j as a graph backend, run with"
"`--quickstart-compose-file ./docker/quickstart/docker-compose.quickstart.yml`")
click.echo("No Datahub Neo4j volume found, starting with elasticsearch as graph service.\n"
"To use neo4j as a graph backend, run \n"
"`datahub docker quickstart --quickstart-compose-file ./docker/quickstart/docker-compose.quickstart.yml`"
"\nfrom the root of the datahub repo\n")
return False


Expand Down