Skip to content

Improve logging in GMS and datahub-frontend #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 19 commits into from
Jun 25, 2021
Merged

Improve logging in GMS and datahub-frontend #2761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
233bc3a
Removing the CleanupStep from DataHub Upgrade
jjoyce0510 Jun 21, 2021
6464bc9
Adding logger classes
jjoyce0510 Jun 22, 2021
3aae831
Adding a logger to datahub-frontend
jjoyce0510 Jun 24, 2021
0b112ef
Adding debug logs
jjoyce0510 Jun 24, 2021
dd32ce8
Resolving conflicts
jjoyce0510 Jun 24, 2021
d7e6156
Adding debug to dev docker-compose deploy
jjoyce0510 Jun 24, 2021
59044a5
Fixing up logback.xml
jjoyce0510 Jun 25, 2021
08d1623
Fixing merge
jjoyce0510 Jun 25, 2021
fd28d75
reset
jjoyce0510 Jun 25, 2021
daecd2e
Adding quickstart
jjoyce0510 Jun 25, 2021
ae85e52
Reverting unnecessary changes
jjoyce0510 Jun 25, 2021
f9308cd
Addressing logging comments
jjoyce0510 Jun 25, 2021
fae11cd
SLF4J logging
jjoyce0510 Jun 25, 2021
e04de0d
Merging master
jjoyce0510 Jun 25, 2021
c17f189
Remove unnecessary loggers
jjoyce0510 Jun 25, 2021
e241762
Fixing files
jjoyce0510 Jun 25, 2021
68ac354
Removing unnecessary changes
jjoyce0510 Jun 25, 2021
f566447
Making debug logging false
jjoyce0510 Jun 25, 2021
833aa34
Regenerate docker quickstart compose
jjoyce0510 Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removing the CleanupStep from DataHub Upgrade
  • Loading branch information
@jjoyce0510
jjoyce0510 committed Jun 21, 2021
commit 233bc3a482c67b4bdf18eb419f69f0bd1ecefbdb
34 changes: 0 additions & 34 deletions datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/nocode/CleanupStep.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/nocode/NoCodeUpgrade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package com.linkedin.datahub.upgrade.nocode;

import com.google.common.collect.ImmutableList;
import com.linkedin.datahub.upgrade.Upgrade;
import com.linkedin.datahub.upgrade.UpgradeCleanupStep;
import com.linkedin.datahub.upgrade.UpgradeStep;
import com.linkedin.metadata.entity.EntityService;
import com.linkedin.metadata.models.registry.SnapshotEntityRegistry;
import io.ebean.EbeanServer;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

public class NoCodeUpgrade implements Upgrade {
Expand Down Expand Up @@ -48,7 +48,7 @@ public List<UpgradeCleanupStep> cleanupSteps() {
}

private List<UpgradeCleanupStep> buildCleanupSteps(final EbeanServer server) {
return ImmutableList.of(new CleanupStep(server));
return Collections.emptyList();
}

private List<UpgradeStep> buildUpgradeSteps(
Expand Down