Skip to content

refactor(ingest): use common get_sys_time method #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 3 commits into from
Jun 29, 2021
Merged

refactor(ingest): use common get_sys_time method #2782

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e21f214
refactor(ingest): use common get_sys_time method
hsheth2 Jun 28, 2021
cdff234
update ignore paths
hsheth2 Jun 28, 2021
688e0cc
fix ignore path
hsheth2 Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update ignore paths
  • Loading branch information
@hsheth2
hsheth2 committed Jun 28, 2021
commit cdff234a6d37bc3f5ead6d6a780132024e94c4b5
2 changes: 2 additions & 0 deletions metadata-ingestion/tests/test_helpers/mce_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ def assert_mces_equal(output: object, golden: object) -> None:
# Ignore timestamps from the ETL pipeline. A couple examples:
# root[0]['proposedSnapshot']['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot']['aspects'][0]['com.linkedin.pegasus2avro.common.Ownership']['lastModified']['time']
# root[69]['proposedSnapshot']['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot']['aspects'][0]['com.linkedin.pegasus2avro.schema.SchemaMetadata']['lastModified']['time']"
# root[0]['proposedSnapshot']['com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot']['aspects'][1]['com.linkedin.pegasus2avro.dataset.UpstreamLineage']['upstreams'][0]['auditStamp']['time']
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['created'\]\['time'\]",
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['lastModified'\]\['time'\]",
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['createStamp'\]\['time'\]",
r"root\[\d+\]\['proposedSnapshot'\].+\['aspects'\].+\['createStamp'\]\['time'\]",
}
diff = deepdiff.DeepDiff(golden, output, exclude_regex_paths=ignore_paths)
assert not diff, str(diff)