Skip to content

fix(ingest): use correct platform for MongoDB ingestion #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 9 commits into from
Jun 29, 2021
Merged

fix(ingest): use correct platform for MongoDB ingestion #2783

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
17fde48
Add mongodb ingestion recipe
kevinhu Jun 25, 2021
e1b7a0b
Merge branch 'linkedin:master' into fix-logos
kevinhu Jun 25, 2021
6d7d237
Merge branch 'master' of github.com:kevinhu/datahub into fix-logos
kevinhu Jun 28, 2021
7f4e0bf
Merge branch 'master' of github.com:kevinhu/datahub into fix-logos
kevinhu Jun 28, 2021
ab3eab2
Fix MongoDB typo
kevinhu Jun 28, 2021
a75ea5e
Update mongo golden
kevinhu Jun 28, 2021
38b4ebd
mongo->mongodb
kevinhu Jun 29, 2021
0ab6dcf
Merge
kevinhu Jun 29, 2021
6bd92ef
More mongo patches
kevinhu Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions metadata-ingestion/examples/recipes/mongodb_to_datahub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
source:
type: "mongodb"
config:
# For advanced configurations, see the MongoDB docs.
# https://pymongo.readthedocs.io/en/stable/examples/authentication.html
connect_uri: "mongodb://localhost:57017"
username: mongoadmin
password: examplepass
env: "PROD" # Optional, default is "PROD"
authMechanism: "DEFAULT"
options: {}
database_pattern: {}
collection_pattern: {}
enableSchemaInference: True
schemaSamplingSize: 1000
# database_pattern/collection_pattern are similar to schema_pattern/table_pattern from above
sink:
type: "datahub-rest"
config:
server: "http://localhost:8080"
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/mongodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def get_field_type(
return SchemaFieldDataType(type=TypeClass())

def get_workunits(self) -> Iterable[MetadataWorkUnit]:
platform = "mongodb"
platform = "mongo"

database_names: List[str] = self.mongo_client.list_database_names()

Expand Down
12 changes: 6 additions & 6 deletions metadata-ingestion/tests/integration/mongodb/mongodb_mces_golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot": {
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongodb,mngdb.emptyCollection,PROD)",
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongo,mngdb.emptyCollection,PROD)",
"aspects": [
{
"com.linkedin.pegasus2avro.dataset.DatasetProperties": {
Expand All @@ -17,7 +17,7 @@
{
"com.linkedin.pegasus2avro.schema.SchemaMetadata": {
"schemaName": "emptyCollection",
"platform": "urn:li:dataPlatform:mongodb",
"platform": "urn:li:dataPlatform:mongo",
"version": 0,
"created": {
"time": 1615443388097,
Expand Down Expand Up @@ -50,7 +50,7 @@
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot": {
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongodb,mngdb.firstCollection,PROD)",
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongo,mngdb.firstCollection,PROD)",
"aspects": [
{
"com.linkedin.pegasus2avro.dataset.DatasetProperties": {
Expand All @@ -64,7 +64,7 @@
{
"com.linkedin.pegasus2avro.schema.SchemaMetadata": {
"schemaName": "firstCollection",
"platform": "urn:li:dataPlatform:mongodb",
"platform": "urn:li:dataPlatform:mongo",
"version": 0,
"created": {
"time": 1615443388097,
Expand Down Expand Up @@ -434,7 +434,7 @@
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DatasetSnapshot": {
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongodb,mngdb.secondCollection,PROD)",
"urn": "urn:li:dataset:(urn:li:dataPlatform:mongo,mngdb.secondCollection,PROD)",
"aspects": [
{
"com.linkedin.pegasus2avro.dataset.DatasetProperties": {
Expand All @@ -448,7 +448,7 @@
{
"com.linkedin.pegasus2avro.schema.SchemaMetadata": {
"schemaName": "secondCollection",
"platform": "urn:li:dataPlatform:mongodb",
"platform": "urn:li:dataPlatform:mongo",
"version": 0,
"created": {
"time": 1615443388097,
Expand Down