Skip to content

fix(ingest): view handling resilience #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 3 commits into from
Jul 2, 2021
Merged

fix(ingest): view handling resilience #2816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef9f41
fix(ingest): handle TextClause view definitions
hsheth2 Jul 1, 2021
aaa5fef
handle view column issues
hsheth2 Jul 1, 2021
a4fc8d8
add warning
hsheth2 Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions metadata-ingestion/src/datahub/ingestion/source/sql_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,19 @@ def loop_views(
self.report.report_dropped(dataset_name)
continue

columns = inspector.get_columns(view, schema)
try:
columns = inspector.get_columns(view, schema)
except KeyError:
# For certain types of views, we are unable to fetch the list of columns.
self.report.report_warning(
dataset_name, "unable to get schema for this view"
)
schema_metadata = None
else:
schema_metadata = get_schema_metadata(
self.report, dataset_name, self.platform, columns
)

try:
# SQLALchemy stubs are incomplete and missing this method.
# PR: https://github.com/dropbox/sqlalchemy-stubs/pull/223.
Expand All @@ -354,6 +366,10 @@ def loop_views(
view_definition = inspector.get_view_definition(view, schema)
if view_definition is None:
view_definition = ""
else:
# Some dialects return a TextClause instead of a raw string,
# so we need to convert them to a string.
view_definition = str(view_definition)
except NotImplementedError:
view_definition = ""
properties["view_definition"] = view_definition
Expand All @@ -370,10 +386,9 @@ def loop_views(
# uri=dataset_name,
)
dataset_snapshot.aspects.append(dataset_properties)
schema_metadata = get_schema_metadata(
self.report, dataset_name, self.platform, columns
)
dataset_snapshot.aspects.append(schema_metadata)

if schema_metadata:
dataset_snapshot.aspects.append(schema_metadata)

mce = MetadataChangeEvent(proposedSnapshot=dataset_snapshot)
wu = SqlWorkUnit(id=dataset_name, mce=mce)
Expand Down