Skip to content

fix(docs): Update OIDC docs #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Jul 2, 2021
Merged

fix(docs): Update OIDC docs #2823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef6702b
Fixing OIDC configuration docs
jjoyce0510 Jul 2, 2021
69cc735
Revert analytics enabled
jjoyce0510 Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixing OIDC configuration docs
  • Loading branch information
@jjoyce0510
jjoyce0510 committed Jul 2, 2021
commit ef6702b3f314669a0f915ccea32f7494c8480007
2 changes: 1 addition & 1 deletion docker/datahub-frontend/env/docker.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ JAVA_OPTS=-Xms256m -Xmx256m -Dhttp.port=9002 -Dconfig.file=datahub-frontend/conf
# AUTH_JAAS_ENABLED=false

# Uncomment to disable persistence of client-side analytics events
# DATAHUB_ANALYTICS_ENABLED=false
DATAHUB_ANALYTICS_ENABLED=false

# Required Kafka Producer Configs
KAFKA_BOOTSTRAP_SERVER=broker:29092
Expand Down
2 changes: 1 addition & 1 deletion docs/how/auth/sso/configure-oidc-react-google.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Replacing the placeholders above with the client id & client secret received fro
Now, simply restart the `datahub-frontend-react` container to enable the integration.

```
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.react.yml restart datahub-frontend-react
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml up datahub-frontend-react
```

Navigate to your DataHub domain to see SSO in action.
Expand Down
2 changes: 1 addition & 1 deletion docs/how/auth/sso/configure-oidc-react-okta.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Replacing the placeholders above with the client id & client secret received fro
Now, simply restart the `datahub-frontend-react` container to enable the integration.

```
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.react.yml restart datahub-frontend-react
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml up datahub-frontend-react
```

Navigate to your DataHub domain to see SSO in action.
Expand Down
2 changes: 1 addition & 1 deletion docs/how/auth/sso/configure-oidc-react.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ as form parameters in the HTTP POST request. For more info, see [OAuth 2.0 Clien
Once configuration has been updated, `datahub-frontend-react` will need to be restarted to pick up the new environment variables:

```
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.react.yml restart datahub-frontend-react
docker-compose -p datahub -f docker-compose.yml -f docker-compose.override.yml up datahub-frontend-react
```

>Note that by default, enabling OIDC will *not* disable the dummy JAAS authentication path, which can be reached at the `/login`
Expand Down