Skip to content

fix(cli): change docker nuke to also remove stopped containers #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 1 commit into from
Jul 3, 2021
Merged

fix(cli): change docker nuke to also remove stopped containers #2825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(cli): change docker nuke to also remove stopped containers
  • Loading branch information
@hsheth2
hsheth2 committed Jul 2, 2021
commit 4401fa4b524619ae8667496ae7fe85438f4abedc
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/cli/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def nuke() -> None:

click.echo("Removing containers in the datahub project")
for container in client.containers.list(
filters={"label": "com.docker.compose.project=datahub"}
all=True, filters={"label": "com.docker.compose.project=datahub"}
):
container.remove(v=True, force=True)

Expand Down