Skip to content

fix(ingest): increasing default ingestion REST timeout to 30 seconds #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Aug 13, 2021
Merged

fix(ingest): increasing default ingestion REST timeout to 30 seconds #3095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c819eb
fix(ingest): increasing default ingestion REST timeout to 30 seconds
shirshanka Aug 13, 2021
8e13dd2
updating docs
shirshanka Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/sink_docs/datahub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Note that a `.` is used to denote nested fields in the YAML recipe.
| Field | Required | Default | Description |
| -------- | -------- | ------- | ---------------------------- |
| `server` | ✅ | | URL of DataHub GMS endpoint. |
| `timeout_sec` | | 2 | Per-HTTP request timeout. |
| `timeout_sec` | | 30 | Per-HTTP request timeout. |

## DataHub Kafka

Expand Down
4 changes: 2 additions & 2 deletions metadata-ingestion/src/datahub/emitter/rest_emitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ def _make_curl_command(


class DatahubRestEmitter:
DEFAULT_CONNECT_TIMEOUT_SEC = 10 # 10 seconds should be plenty to connect
DEFAULT_CONNECT_TIMEOUT_SEC = 30 # 30 seconds should be plenty to connect
DEFAULT_READ_TIMEOUT_SEC = (
2 # Any ingest call taking longer than 2 seconds should be abandoned
30 # Any ingest call taking longer than 30 seconds should be abandoned
)

_gms_server: str
Expand Down