Skip to content

feat(ingest): support for env variable in cli #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 8 commits into from
Sep 17, 2021
Merged

feat(ingest): support for env variable in cli #3215

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd5489b
feat(ingest): support for env variable in cli
aseembansal-gogo Sep 9, 2021
89488a2
feat(ingest): add error on missing config, add a test
aseembansal-gogo Sep 12, 2021
7851207
feat(ingest): fix docs
aseembansal-gogo Sep 12, 2021
cf14f77
feat(ingest): fix docs
aseembansal-gogo Sep 12, 2021
fa3e1b9
feat(ingest): fix formatting
aseembansal-gogo Sep 12, 2021
5a53e0d
feat(ingest): extract env var name, add type annotations
aseembansal-gogo Sep 12, 2021
cc522da
feat(ingest): consistent names
aseembansal-gogo Sep 12, 2021
12d3707
feat(ingest): code review comments
aseembansal-gogo Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(ingest): fix docs
  • Loading branch information
@aseembansal-gogo
aseembansal-gogo committed Sep 12, 2021
commit cf14f77c87ae8c0e5538f1acdef3e81b352284db
2 changes: 1 addition & 1 deletion docs/how/delete-metadata.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ DATAHUB_GMS_HOST=http://localhost:8080
DATAHUB_GMS_TOKEN=
```

The env variables for host and token will be used only if `DATAHUB_SKIP_CONFIG` is set.
The env variables take precendence over what is in the config.

## Delete By Urn

Expand Down