Skip to content

fix(dataset profiles) compatibility with older indices. #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 6 commits into from
Sep 15, 2021
Merged

fix(dataset profiles) compatibility with older indices. #3242

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
479f105
fix(local-dev): fix proxy for login route (#236)
gabe-lyons Sep 9, 2021
38a99f7
Revert "fix(local-dev): fix proxy for login route (#236)"
gabe-lyons Sep 9, 2021
489fe75
Merge branch 'master' of https://github.com/acryldata/datahub-fork
Sep 9, 2021
8e0f9ba
Merge branch 'master' of https://github.com/linkedin/datahub
Sep 14, 2021
d9a38d4
Merge branch 'master' of https://github.com/acryldata/datahub-fork
rslanka Sep 15, 2021
c1439aa
fix(dataset profiles): Change the test for un-exploded rows to work w…
rslanka Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fix(local-dev): fix proxy for login route (#236)" 
This reverts commit 479f105.
  • Loading branch information
@gabe-lyons
gabe-lyons committed Sep 9, 2021
commit 38a99f70b8f46be16380a32144c1d9d5862c85d1
6 changes: 1 addition & 5 deletions datahub-web-react/src/setupProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
const logInFilter = function (pathname, req) {
return pathname.match('^/logIn') && req.method === 'POST';
};

if (process.env.REACT_APP_MOCK === 'true' || process.env.REACT_APP_MOCK === 'cy') {
// no proxy needed, MirageJS will intercept all http requests
module.exports = function () {};
Expand All @@ -12,7 +8,7 @@ if (process.env.REACT_APP_MOCK === 'true' || process.env.REACT_APP_MOCK === 'cy'
module.exports = function (app) {
app.use(
'/logIn',
createProxyMiddleware(logInFilter, {
createProxyMiddleware({
target: 'http://localhost:9002',
changeOrigin: true,
}),
Expand Down