Don't write a spurious SelfLog event when disposing an unused sink in durable mode#231
Merged
nblumhardt merged 1 commit intodatalust:devfrom Dec 1, 2024
Conversation
This was referenced Apr 20, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198
The construction of a bookmark file normally creates one if it doesn't already exist. This PR follows the behavior of the "write" path by also attempting to create the directory if necessary (
Directory.CreateDirectory()is idempotent).Although it can't be exercised currently, this would also prevent a potential startup-time race condition if the shipper were to get started before, or faster than, the file sink.