Fix(ruleset): [schema] Enhance schema compliance and remove redundancies #670
+314
−316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key improvements to the
rule.schema.jsonandruleset.schema.jsonfiles to enhance their compliance and reduce redundancies:JSON Schema Draft 7 Compatibility (Fixes issue The schemas follow the JSON Schema Draft 7 dialect but make use of the
$defskeyword #669):$defstodefinitionsand their corresponding$refpointers.$defskeyword was introduced in JSON Schema 2019-09, making itincompatible with the declared Draft 7 schemas. This change ensures
schemas compile correctly with strict evaluators like Blaze.
Remove Redundant 'type' Declarations with 'enum':
type: "string"alongside
enumfor properties in both schemas.the explicit
typedeclaration redundant.Schema best practices.
These combined changes lead to more robust and compliant schema definitions.
Note: These auto-fixes were made with the help of sourcemeta's jsonschema cli , we are improving the linter and defining linting rules as part of a GSoC project. If helpful, I could help integrate the linter with the schemas in the repo, so it can help flag and fix redundancies and errors