Add individual released gems info into commit message. #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
reviewed
Sep 23, 2023
| @gem_info_list.each do |info| | ||
| gem_line = " * **#{info.gem_name} #{info.new_version}**" | ||
| gem_line += info.last_version ? " (was #{info.last_version})" : " (initial release)" | ||
| @release_commit_title += gem_line + "\n" |
Owner
There was a problem hiding this comment.
The commit title is used for the pull request title as well as the commit message, so we probably can't make it multiple lines. However, I think I see where you're going with this; let me open an alternate PR.
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
Hello, this is naive approach to implement an idea of adding also gem release info into multi release commit message.
motivation
In recent weeks I was trying to get familiar with opentelemetry-ruby and often I have seen commits like open-telemetry/opentelemetry-ruby@a7bd62a. It is not possible to find out what was released looking just at commit message. For me, it would be super helpful to include this info as part of commit message.