This repository was archived by the owner on Sep 2, 2025. It is now read-only.
fix whitespace issue with incremental sql #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
McKnight-42
approved these changes
Jan 9, 2023
dbeatty10
reviewed
Jan 9, 2023
dbeatty10
previously requested changes
Jan 9, 2023
Contributor
dbeatty10
left a comment
dbeatty10
left a comment
There was a problem hiding this comment.
There are a couple failing tests related to Python 3.11.
Could we take a look at those to determine the cause?
colin-rogers-dbt
dismissed
dbeatty10’s stale review
fixed python build issues for 3.11
dbeatty10
reviewed
Jan 9, 2023
| run: | | ||
| python -m pip install --user --upgrade pip | ||
| python -m pip install --upgrade wheel | ||
| python -m pip install --upgrade wheel setuptools twine check-wheel-contents |
Contributor
There was a problem hiding this comment.
Did adding the following turn out to be necessary?
- setuptools
- twine
- check-wheel-contents
If they aren't strictly necessary, I'd advocate for peeling them out.
dbeatty10
reviewed
Jan 9, 2023
| {%- else -%} | ||
| {{sql}} | ||
| {%- endif -%} | ||
| {%- endif %} |
2 tasks
3 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #457
Description
Remove trailing whitespace elimination in bq_generate_incremental_merge_build_sql
Checklist
changie newto create a changelog entry