Skip to content

[CT-1998] Improve handling of dictionaries in protobuf messages #6832

@gshank

Description

@gshank

In pull request #6820 we implemented protobuf message versions of nodes and node configs. However the match between Python dictionaries that allow values of any type and protobuf maps isn't straightforward. As a result we have temporarily forced a number of dictionaries into string/string dictionaries.

We should look at other options for this and improve the representation of dictionaries in protobuf messages. In particularly this applies to the "meta" dictionary, which is already included in 1.4 in the node_info structures in the logs.

In addition to "meta", the following dictionaries are affected:

  • in NodeConfig - persist_docs, quoting, column_types, grants
  • in ColumnInfo - _extra
  • in various nodes - unrendered_config
  • in TestMetadata - kwargs
  • in SourceDefinitino - source_meta

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions