fix: use tuple membership check instead of substring match in selection_arg#12562
Open
kalluripradeep wants to merge 2 commits intodbt-labs:mainfrom
Open
fix: use tuple membership check instead of substring match in selection_arg#12562kalluripradeep wants to merge 2 commits intodbt-labs:mainfrom
kalluripradeep wants to merge 2 commits intodbt-labs:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12539
What changed
Fixed a one-character bug in
core/dbt/task/show.pyandcore/dbt/task/compile.pywhereself.selection_arg[0]was usedinstead of
self.selection_argin the result filtering loop.Why
self.selection_argis a tuple like('my_model_show',).Using
result.node.name in self.selection_arg[0]does a substringcheck on a string, not a membership check on the tuple:
So any model whose name contained a common substring like
show,model, ormywould incorrectly match other nodes during resultfiltering, causing inconsistent behaviour depending on the model name.
How I fixed it
Removed the
[0]index in both files so the check becomes a propertuple membership check:
Files changed
core/dbt/task/show.pycore/dbt/task/compile.py