fix: multiple calls of dbt-retry fail with exit code 2#12627
Open
showyou wants to merge 3 commits intodbt-labs:mainfrom
Open
fix: multiple calls of dbt-retry fail with exit code 2#12627showyou wants to merge 3 commits intodbt-labs:mainfrom
showyou wants to merge 3 commits intodbt-labs:mainfrom
Conversation
multiple calls of dbt retry (dbt-labs#8848)
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @showyou |
Author
|
I have submitted the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8848
Problem
When calling dbt retry multiple times, if the previous run returned zero results and completed successfully, the next run resulted in an error.
The cause is as described in the issue, but to put it simply: when the count of results in the ExecutionResult class is 0,
not self.previous_resultsevaluates to True in dbt/core/dbt/task/retry.py, leading to unexpected results.Solution
have been changed to
I also added test class about this issue.
Checklist