Skip to content

Fix macro namespace search packages #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshank merged 8 commits into from
Jun 27, 2023
Merged

Fix macro namespace search packages #5804

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1a94a15
Refactor a chunk of code (for packages to search for a macro name) as…
dbeatty10 Sep 9, 2022
0f57cbb
Remove extraneous variable name
dbeatty10 Sep 9, 2022
a393c44
Use type annotations
dbeatty10 Sep 9, 2022
d3083f3
Changelog entry
dbeatty10 Sep 9, 2022
6c0976a
Merge branch 'main' into dbeatty/fix-macro-namespace-search-packages
dbeatty10 Sep 10, 2022
bf7927d
Merge branch 'main' into dbeatty/fix-macro-namespace-search-packages
dbeatty10 Jun 23, 2023
8aff7ac
Functional test when the macro is not found in the namespace
dbeatty10 Jun 23, 2023
ae5fcd0
Improve the error message
dbeatty10 Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove extraneous variable name
  • Loading branch information
@dbeatty10
dbeatty10 committed Sep 9, 2022
commit 0f57cbbe13ab3237fc168ef098953f5c642d7813
6 changes: 2 additions & 4 deletions core/dbt/context/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,7 @@ def _get_adapter_macro_prefixes(self) -> List[str]:
search_prefixes = get_adapter_type_names(self._adapter.type()) + ["default"]
return search_prefixes

def _get_search_packages(self, macro_namespace: Optional[str] = None):
namespace = macro_namespace

def _get_search_packages(self, namespace: Optional[str] = None):
if namespace is None:
search_packages = [None]
elif isinstance(namespace, str):
Expand All @@ -137,7 +135,7 @@ def _get_search_packages(self, macro_namespace: Optional[str] = None):
# Not a string and not None so must be a list
raise CompilationException(
f"In adapter.dispatch, got a list macro_namespace argument "
f'("{macro_namespace}"), but macro_namespace should be None or a string.'
f'("{namespace}"), but macro_namespace should be None or a string.'
)

return search_packages
Expand Down