Updated string formatting on non-f-strings.#6086
Merged
emmyoop merged 2 commits intodbt-labs:mainfrom Oct 17, 2022
Merged
Conversation
Found all cases of strings separated by white space on a single line and removed white space separation. EX: "hello " "world" -> "hello world".
Contributor
Author
|
Completed changie entry |
Contributor
Author
I think I did this by running |
Contributor
|
Yay! |
Member
|
@luke-bassett it looks like your changelog did not make it into the fork. You'll need to get that added before I can approve this. |
Contributor
Author
|
@emmyoop Oops, didn't realize I needed to commit it to the repo. Now it's there I think. |
emmyoop
approved these changes
Oct 17, 2022
Member
emmyoop
left a comment
emmyoop
left a comment
There was a problem hiding this comment.
Thanks so much for you contribution @luke-bassett and participating in the Hackathon!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves
This resolves the non-f-string portion of this issue #6068. The rest was covered by this PR #6082.
Description
Found all cases of strings separated by white space on a single line and
removed white space separation. EX: "hello " "world" -> "hello world".
Checklist
changie newto create a changelog entry