Skip to content

consolidate flags #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenyuLInx merged 17 commits into from
Feb 7, 2023
Merged

consolidate flags #6788

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0a27d1e
remove global WIP
ChenyuLInx Jan 27, 2023
b1e8bf6
flags mostly working, missing dir set from previous
ChenyuLInx Jan 31, 2023
8ed644f
more work on flags
ChenyuLInx Jan 31, 2023
2662ed7
29 tests failing
ChenyuLInx Feb 1, 2023
8127f18
flags mostly working
ChenyuLInx Feb 2, 2023
52124e0
remove test/integration
ChenyuLInx Feb 2, 2023
c332835
more flag fix
ChenyuLInx Feb 2, 2023
28b088e
remove running integration test
ChenyuLInx Feb 2, 2023
0e6a888
remove one global
ChenyuLInx Feb 2, 2023
196efac
set_args in deprecation unit test + use renamed flags as globals
MichelleArk Feb 3, 2023
f31f611
fix manifest unit test, s/DUPLICATE_PARAMS/EXPECTED_DUPLICATE_PARAMS,…
MichelleArk Feb 3, 2023
ed1b5d4
fix --version
MichelleArk Feb 3, 2023
e11602e
test_config mostly passing
MichelleArk Feb 3, 2023
00da2a1
load log-path from dbt_project.yml
MichelleArk Feb 3, 2023
9cbe68c
try/except dbtProjectError when loading log-path from dbt_project.yml
MichelleArk Feb 6, 2023
9b9c908
update default log_path
ChenyuLInx Feb 7, 2023
89ff58a
Add generated CLI API docs
FishtownBuildBot Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update default log_path
  • Loading branch information
@ChenyuLInx
ChenyuLInx committed Feb 7, 2023
commit 9b9c9080ec3b161e4a3fa4323f30263d2e0a7b54
2 changes: 1 addition & 1 deletion core/dbt/cli/flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def assign_params(ctx, params_assigned_from_default):
partial = PartialProject.from_project_root(
project_dir, verify_version=getattr(self, "VERSION_CHECK", True)
)
log_path = str(partial.project_dict.get("log-path"))
log_path = str(partial.project_dict.get("log-path", log_path))
except DbtProjectError:
pass

Expand Down