Skip to content

dbt_project.yml log-path respects project directory #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 8 commits into from
Feb 14, 2023
Merged

dbt_project.yml log-path respects project directory #6908

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d72cf71
write logs to test project in test
MichelleArk Feb 8, 2023
a1a3876
logs_dir cleanup
MichelleArk Feb 8, 2023
6cbadc4
read from logs_dir in test_profile_env_vars
MichelleArk Feb 8, 2023
23aec6b
refactor to default_log_path + unit testing
MichelleArk Feb 14, 2023
182fdf3
Add generated CLI API docs
FishtownBuildBot Feb 14, 2023
aa993b0
move test_resolvers to tests/functional/cli
MichelleArk Feb 14, 2023
8ed5876
Merge branch 'main' into arky/fix-log-path-test
MichelleArk Feb 14, 2023
dca8acf
Add generated CLI API docs
FishtownBuildBot Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions core/dbt/cli/flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from importlib import import_module
from multiprocessing import get_context
from pprint import pformat as pf
from pathlib import Path
from typing import Set, List

from click import Context, get_current_context, BadOptionUsage
Expand All @@ -15,6 +16,8 @@
from dbt.helper_types import WarnErrorOptions
from dbt.config.project import PartialProject
from dbt.exceptions import DbtProjectError
from dbt.cli.resolvers import default_project_dir


if os.name != "nt":
# https://bugs.python.org/issue41567
Expand Down Expand Up @@ -133,20 +136,19 @@ def assign_params(ctx, params_assigned_from_default):
# Default LOG_PATH from PROJECT_DIR, if available.
if getattr(self, "LOG_PATH", None) is None:
log_path = "logs"
project_dir = getattr(self, "PROJECT_DIR", None)
# If available, set LOG_PATH from log-path in dbt_project.yml
# Known limitations:
# 1. Using PartialProject here, so no jinja rendering of log-path.
# 2. Programmatic invocations of the cli via dbtRunner may pass a Project object directly,
# which is not being used here to extract log-path.
if project_dir:
try:
partial = PartialProject.from_project_root(
project_dir, verify_version=getattr(self, "VERSION_CHECK", True)
)
log_path = str(partial.project_dict.get("log-path", log_path))
except DbtProjectError:
pass
project_dir = getattr(self, "PROJECT_DIR", default_project_dir())
try:
partial = PartialProject.from_project_root(
project_dir, verify_version=getattr(self, "VERSION_CHECK", True)
)
log_path = Path(project_dir) / partial.project_dict.get("log-path", log_path)
except DbtProjectError:
pass

object.__setattr__(self, "LOG_PATH", log_path)

Expand Down