Fix Project Env Var Tests #6916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranke
changed the base branch from
main
to
jerco/fix-test_builtin_invocation_args_dict_function
stu-k
approved these changes
Feb 9, 2023
aranke
changed the base branch from
jerco/fix-test_builtin_invocation_args_dict_function
to
feature/click-cli
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
reviewed
Feb 9, 2023
| run_dbt(["run"], expect_pass=False) | ||
|
|
||
| log_output = Path(project.project_root, "logs", "dbt.log").read_text() | ||
| log_output = Path(project.logs_dir, "dbt.log").read_text() |
Contributor
There was a problem hiding this comment.
I ended up doing something very similar in my attempt to fix this but @gshank raises a really good point in this comment - why is this test is now throwing an error in click-cli when it doesn't in main?
Contributor
Author
There was a problem hiding this comment.
I have no idea, but not sure if it's worth investigating since this is the intended behavior.
iknox-fa
approved these changes
Feb 9, 2023
Contributor
iknox-fa
left a comment
iknox-fa
left a comment
There was a problem hiding this comment.
Oh my, so much churn for one tiny test!
This LGTM, let's ship it!
aranke
force-pushed
the
fix_test_pp_vars
branch
from
5aa9f02 to
ccb5659
Compare
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Description
Checklist
changie newto create a changelog entry