Skip to content

CT 1921 add missing nodes to previous state test #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshank merged 11 commits into from
Feb 14, 2023
Merged

CT 1921 add missing nodes to previous state test #6961

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d0aa92
Update v8 manifest.json, test_previous_version_state.py to have more
gshank Feb 7, 2023
2296f59
Add v7/manifest.json
gshank Feb 7, 2023
65ae9f7
different numbers of results for different versions
gshank Feb 8, 2023
4c6d16b
Merge branch 'main' into ct-1921-previous_state_test
gshank Feb 10, 2023
aefb537
Merge branch 'main' into ct-1921-previous_state_test
gshank Feb 10, 2023
3072f55
Add 9 disabled nodes
gshank Feb 13, 2023
ca6c2b7
Update v8 manifest.json, definition of diabled in WritableManifest
gshank Feb 13, 2023
96c7886
Add v7.manifest.json
gshank Feb 13, 2023
8a16806
Merge branch 'main' into ct-1921-previous_state_test
gshank Feb 13, 2023
8415ffb
Changie
gshank Feb 13, 2023
24ab3d0
Switch to a state:modified command which return 0 results
gshank Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Switch to a state:modified command which return 0 results
  • Loading branch information
@gshank
gshank committed Feb 14, 2023
commit 24ab3d0e5b214f2757efe786dbe01d64edd365b9
8 changes: 3 additions & 5 deletions tests/functional/artifacts/test_previous_version_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,18 +293,16 @@ def compare_previous_state(
state_path = os.path.join(project.test_data_dir, f"state/v{compare_manifest_version}")
cli_args = [
"list",
"--resource-types",
"model",
"--select",
"state:modified",
"--state",
state_path,
]
if expect_pass:
results = run_dbt(cli_args, expect_pass=expect_pass)
# We have different numbers of nodes in older versions
if compare_manifest_version < 7:
assert len(results) == 5
else:
assert len(results) == 1
assert len(results) == 0
else:
with pytest.raises(IncompatibleSchemaError):
run_dbt(cli_args, expect_pass=expect_pass)
Expand Down