Skip to content

get_column_schema_from_query macro #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichelleArk merged 19 commits into from
Mar 3, 2023
Merged

get_column_schema_from_query macro #6986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e8399cd
Experiment: column types from empty query
jtcohen6 Jan 20, 2023
0a9391a
use get_empty_schema_sql to get column schema from schema yml
MichelleArk Feb 15, 2023
02d2c5c
polish + test__constraints_wrong_column_data_types
MichelleArk Feb 22, 2023
bef70fc
changelog entry
MichelleArk Feb 22, 2023
e1ed713
get_column_schema_from_query documentation
MichelleArk Feb 22, 2023
80d622a
use column.data_type in format_columns
MichelleArk Feb 22, 2023
343d95b
parametrize BaseConstraintsColumnsEqual tests to types
MichelleArk Feb 22, 2023
425520a
log formatted title + column on same line
MichelleArk Feb 23, 2023
266bdec
default format_column
MichelleArk Feb 23, 2023
02ad29d
Merge branch 'main' into CT-1919/get_column_schema_from_query_macro2
MichelleArk Feb 23, 2023
b629e34
s/constraints_enabled/contract
MichelleArk Feb 23, 2023
d3a4412
fix signature of SQLConnectionManager.data_type_code_to_name
MichelleArk Feb 28, 2023
5a796f2
Merge branch 'main' into CT-1919/get_column_schema_from_query_macro2
MichelleArk Feb 28, 2023
99a4ef7
Add generated CLI API docs
FishtownBuildBot Feb 28, 2023
de39489
better docstrings + comments in macros
MichelleArk Feb 28, 2023
02cd444
remove get_column_schema_from_query from ConnectionManager
MichelleArk Mar 2, 2023
5858095
add_select_query
MichelleArk Mar 2, 2023
60fa84e
test more types! + correct data_type schemas
MichelleArk Mar 3, 2023
a630793
fix typo
MichelleArk Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
s/constraints_enabled/contract
  • Loading branch information
@MichelleArk
MichelleArk committed Feb 23, 2023
commit b629e344cdb390878d066e7c702575b25407aa63
2 changes: 1 addition & 1 deletion tests/adapter/dbt/tests/adapter/constraints/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
data_type: date
- name: my_model_wrong_data_type
config:
constraints_enabled: true
contract: true
columns:
- name: id
data_type: integer
Expand Down
4 changes: 2 additions & 2 deletions tests/adapter/dbt/tests/adapter/constraints/test_constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ def test__constraints_wrong_column_data_types(
manifest = get_manifest(project.project_root)
model_id = "model.test.my_model_wrong_data_type"
my_model_config = manifest.nodes[model_id].config
constraints_enabled_actual_config = my_model_config.constraints_enabled
contract_actual_config = my_model_config.contract

assert constraints_enabled_actual_config is True
assert contract_actual_config is True

expected_compile_error = "Please ensure the name, data_type, order, and number of columns in your `yml` file match the columns in your SQL file."
expected_schema_file_columns = f"Schema File Columns: id {int_type}, color {string_type}, date_day DATE, num_array {int_array_type}"
Expand Down