Skip to content

Make version configs optional #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshank merged 15 commits into from
Mar 10, 2023
Merged

Make version configs optional #7060

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2599f03
allow optional config-version
dave-connors-3 Feb 27, 2023
7d66804
remove schema yml version missing error
dave-connors-3 Feb 27, 2023
caa0c9d
mkae version optional, default 2
dave-connors-3 Feb 27, 2023
5c08e50
add tests for config-version and schema yml version
dave-connors-3 Feb 27, 2023
12fc8b0
say changie
dave-connors-3 Feb 27, 2023
db84daa
update old test with non int value
dave-connors-3 Feb 27, 2023
53c3a82
remove get method and version check for config-version from project.py
dave-connors-3 Mar 9, 2023
733789d
remove check_format_version
dave-connors-3 Mar 9, 2023
681a76c
deprecate schema version exceptions
dave-connors-3 Mar 9, 2023
d8190d5
revert the pop method logic changes
dave-connors-3 Mar 9, 2023
2d0a687
remove config-version from global project config dict test fixture
dave-connors-3 Mar 9, 2023
a63da5a
revert non-int config-version in test
dave-connors-3 Mar 9, 2023
40db0c3
remove references to old method
dave-connors-3 Mar 9, 2023
5b7ffc4
remove test_unsupported_version
dave-connors-3 Mar 9, 2023
8dc9f64
resolve conflicts
dave-connors-3 Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert non-int config-version in test
  • Loading branch information
@dave-connors-3
dave-connors-3 committed Mar 9, 2023
commit a63da5a64041a981ab54a4bb34b74b2bc43be543
2 changes: 1 addition & 1 deletion test/unit/test_contracts_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

from .utils import ContractTestCase

from dbt.dataclass_schema import ValidationError
Expand Down Expand Up @@ -42,7 +43,6 @@ def test_unsupported_version(self):
'version': '1.0',
'profile': 'test',
'project-root': '/usr/src/app',
'config-version': 'non-int',
}
with self.assertRaises(Exception):
self.ContractType.from_dict(dct)