ct-2198: Unify constraints and check_constraints fields#7130
Merged
peterallenwebb merged 22 commits intomainfrom Mar 22, 2023
Merged
ct-2198: Unify constraints and check_constraints fields#7130peterallenwebb merged 22 commits intomainfrom
peterallenwebb merged 22 commits intomainfrom
Conversation
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
requested changes
Mar 7, 2023
Contributor
gshank
left a comment
gshank
left a comment
There was a problem hiding this comment.
This looks pretty good, except that the field I put in the wrong place should be moved :)
peterallenwebb
changed the title
* first pass * rename tests * fix failing test * changelog * fix functional test * Update core/dbt/parser/base.py * Update core/dbt/parser/schemas.py
…#7115) * update to allow adapters to change model name resolution in py models * add changie * fix newline adds * move quoting into macro * use single quotes
Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
MichelleArk
approved these changes
Mar 15, 2023
peterallenwebb
commented
Mar 15, 2023
gshank
previously requested changes
Mar 16, 2023
Contributor
gshank
left a comment
gshank
left a comment
There was a problem hiding this comment.
I don't think this handles invalid column level constraint types.
mikealfare
reviewed
Mar 17, 2023
core/dbt/include/global_project/macros/materializations/models/table/columns_spec_ddl.sql
Outdated
Show resolved
Hide resolved
plugins/postgres/dbt/include/postgres/macros/utils/columns_spec_ddl.sql
Outdated
Show resolved
Hide resolved
mikealfare
approved these changes
Mar 19, 2023
MichelleArk
reviewed
Mar 21, 2023
core/dbt/adapters/base/impl.py
Outdated
| return model_context[macro_name] | ||
|
|
||
| @classmethod | ||
| def _parse_constraint(cls, raw_constraint: Dict[str, Any]) -> ColumnLevelConstraint: |
Contributor
There was a problem hiding this comment.
naming nit: _parse_column_constraint
MichelleArk
reviewed
Mar 21, 2023
MichelleArk
approved these changes
Mar 21, 2023
Contributor
MichelleArk
left a comment
MichelleArk
left a comment
There was a problem hiding this comment.
LGTM! A couple comments, nothing blocking.
peterallenwebb
dismissed
gshank’s stale review
Already addressed requested changes.
gshank
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #7066
Description
Checklist
changie newto create a changelog entry