Skip to content

add negative part number test case for split part cross db util #7200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbeatty10 merged 6 commits into from
Jul 11, 2023
Merged

add negative part number test case for split part cross db util #7200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5fb7c76
add negative test case
dave-connors-3 Mar 20, 2023
8c64e80
changie
dave-connors-3 Mar 20, 2023
83c97ca
missed a comma
dave-connors-3 Mar 20, 2023
7559214
Update changelog entry
dbeatty10 Jun 21, 2023
03cf6b5
Merge branch 'main' into split-part-negative-part-number
dbeatty10 Jul 10, 2023
70d4217
Add a negative number (rather than subtract a positive number)
dbeatty10 Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230320-153225.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: add negative part_number arg for split part macro
time: 2023-03-20T15:32:25.5932-05:00
custom:
Author: dave-connors-3
Issue: "7915"
2 changes: 1 addition & 1 deletion core/dbt/include/global_project/macros/utils/split_part.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
length({{ string_text }})
- length(
replace({{ string_text }}, {{ delimiter_text }}, '')
) + 2 {{ part_number }}
) + 2 + {{ part_number }}
)

{% endmacro %}
16 changes: 12 additions & 4 deletions tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# split_part

seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3
a|b|c,|,a,b,c
1|2|3,|,1,2,3
,|,,,
seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3,result_4
a|b|c,|,a,b,c,c
1|2|3,|,1,2,3,3
,|,,,,
"""


Expand Down Expand Up @@ -34,6 +34,14 @@
{{ split_part('parts', 'split_on', 3) }} as actual,
result_3 as expected

from data

union all

select
{{ split_part('parts', 'split_on', -1) }} as actual,
result_4 as expected

from data
"""

Expand Down