Generalize constraint warnings by emmyoop · Pull Request #7250 · dbt-labs/dbt-core

emmyoop · 2023-03-31T18:22:44Z

resolves #7067

Centralizes warnings so adapters just need to set the constraint_support property.

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

core/dbt/include/global_project/macros/materializations/models/table/columns_spec_ddl.sql

plugins/postgres/dbt/adapters/postgres/impl.py

core/dbt/adapters/base/impl.py

core/dbt/events/types.py

peterallenwebb

Overall this is looking really good, just had one final question and one final suggestion.

core/dbt/adapters/base/impl.py

core/dbt/include/global_project/macros/materializations/models/table/columns_spec_ddl.sql

core/dbt/events/types.py

core/dbt/adapters/base/impl.py

VersusFacit

Just a few comments but this one looks largely good.

core/dbt/contracts/graph/nodes.py

cla-bot bot added the cla:yes label Mar 31, 2023

emmyoop changed the title ~~Generalize constraing warnings~~ Generalize constraint warnings Mar 31, 2023

MichelleArk reviewed Mar 31, 2023

View reviewed changes

core/dbt/include/global_project/macros/materializations/models/table/columns_spec_ddl.sql Outdated Show resolved Hide resolved

MichelleArk reviewed Mar 31, 2023

View reviewed changes

plugins/postgres/dbt/adapters/postgres/impl.py Outdated Show resolved Hide resolved

MichelleArk reviewed Apr 3, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

MichelleArk reviewed Apr 3, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

MichelleArk reviewed Apr 4, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

emmyoop force-pushed the er/ct-2199-constraint-support branch from e31ec8d to 65a6172 Compare April 4, 2023 13:44

MichelleArk reviewed Apr 4, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

MichelleArk reviewed Apr 4, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

emmyoop marked this pull request as ready for review April 4, 2023 15:58

emmyoop requested review from a team as code owners April 4, 2023 15:58

emmyoop requested review from gshank and nathaniel-may April 4, 2023 15:58

MichelleArk reviewed Apr 5, 2023

View reviewed changes

core/dbt/events/types.py Outdated Show resolved Hide resolved

emmyoop force-pushed the er/ct-2199-constraint-support branch 2 times, most recently from b5f557d to ee8fdcd Compare April 7, 2023 12:38

peterallenwebb reviewed Apr 7, 2023

View reviewed changes

core/dbt/adapters/base/impl.py Show resolved Hide resolved

core/dbt/adapters/base/impl.py Outdated Show resolved Hide resolved

emmyoop requested review from MichelleArk and peterallenwebb April 10, 2023 15:33

emmyoop force-pushed the er/ct-2199-constraint-support branch 2 times, most recently from 34e3c74 to 8c98faf Compare April 10, 2023 17:33