Remove noisy parse events #7388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6671
Description
I'd like to remove these events! They're noisy, they add a lot of clutter to debug-level logs, and I don't think they're particularly helpful in debugging (even while debugging parsing errors) — certainly not as much as doing a better job of tracing parsing errors to specific lines/files, or
try-catching to handle them more gracefully.As it turns out,
MacroFileParseandGenericTestFileParsehave already been effectively disabled in v1.5, because they were placed under anif get_flags().MACRO_DEBUGGING(??) conditional.For the sake of
test_all_experimental_parser, we still need to fire theNoteevents during model parsing, but only when running tests. I switched these out forfire_event_if, and borrowed this bit of logic from the event system as the conditional. I'm happy to rework this in a way that's less repetitive.Honestly, the functional test itself could probably use a refactor, but I didn't see a quick way to go about that within the scope of this (much smaller) issue.
Checklist
changie newto create a changelog entry